Add normalizer rules for $defs and const#290
Merged
Merged
Conversation
Owner
|
Thanks for the contribution! Mind adding some basic tests to make sure this doesn’t regress in the future? |
|
It would be nice to have this merged since other tooling has already moved to https://json-schema.org/draft/2019-09/schema. |
|
@bcherny Are the tests fine? |
bcherny
approved these changes
Dec 19, 2020
Owner
bcherny
left a comment
bcherny
left a comment
There was a problem hiding this comment.
Looks great. Thank you for the contribution!
bcherny
requested changes
Dec 19, 2020
Owner
bcherny
left a comment
bcherny
left a comment
There was a problem hiding this comment.
Mind rebasing? Then I'll go ahead and merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for newer keywords which have previous equivalents:
$defsis mapped todefinitionsconstis mapped to a singletonenum